[Metricbeat] Mocked Tests: Do not halt if doc check fails#11780
Merged
sayden merged 3 commits intoelastic:masterfrom Apr 15, 2019
Merged
[Metricbeat] Mocked Tests: Do not halt if doc check fails#11780sayden merged 3 commits intoelastic:masterfrom
sayden merged 3 commits intoelastic:masterfrom
Conversation
sayden
added
enhancement
Metricbeat
ruflin
approved these changes
Apr 15, 2019
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM
+1 on making errors more descriptive, this is especially useful for community contributors and new joiners.
Could you rebase on master? I think I saw a PR that skipped the KB issue.
sayden
force-pushed
the
feature/mb/do-not-halt-in-doc-check
branch
from
44f24c2 to
b1995be
Compare
ruflin
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current behaviour, tests halt if doc checks can't find a field and the
-expected.jsonfile is not written. With this change, the file is written at least, helping identifying the issue.@ruflin I was wondering if descriptive errors which leads to the solution to developers and contributors are a way to go as a general rule. In this particular context, I was about to write a very long and descriptive error here because I realized that a field that exists in
{module}/{metricset}/_meta/fields.ymlcan still be missing in rootfields.ymland throw an error... which confused me for a while until I thought to try with amake update. WDYT?