Skip to content

Add no_dashboards flag to Heartbeat docs#11769

Merged
dedemorton merged 1 commit intoelastic:masterfrom
dedemorton:hb_no_dashboards
Apr 15, 2019
Merged

Add no_dashboards flag to Heartbeat docs#11769
dedemorton merged 1 commit intoelastic:masterfrom
dedemorton:hb_no_dashboards

Conversation

@dedemorton
Copy link
Copy Markdown
Contributor

Adds no_dashboards flag to suppress shared docs that discuss dashboard loading via setup.

Also fixes a few places where we mention dashboards, but shouldn't.

@dedemorton dedemorton requested review from a team as code owners April 11, 2019 20:21
@dedemorton dedemorton added the needs_backport PR is waiting to be backported to other branches. label Apr 12, 2019
@ruflin ruflin requested a review from dov0211 April 15, 2019 10:39
Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dov0211 Could you also check this after it's merged and deployed on elastic.co to make sure it looks as expected?

@dedemorton dedemorton merged commit e2b1084 into elastic:master Apr 15, 2019
@dedemorton dedemorton deleted the hb_no_dashboards branch April 15, 2019 18:19
@dov0211
Copy link
Copy Markdown

dov0211 commented Apr 16, 2019

@ruflin checked on Master LGTM

dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 16, 2019
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants