Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure topbeat to make functions available as library #1172

Merged
merged 1 commit into from
Mar 21, 2016

Conversation

ruflin
Copy link
Collaborator

@ruflin ruflin commented Mar 16, 2016

Topbeat has lots of functionality which can be reused in other libraries, especially topbeat. To decouple the functionality from topbeat, this PR restructures Topbeat into the beater part and the library part. This makes is possible to reuse and share the functionality between Topbeat and Metricbeat.

Further steps should be taken later to also better split up the testing and introduce ucfg in topbeat.

This refactoring did not change any functionality or output of topbeat.

@tsg
Copy link
Contributor

tsg commented Mar 16, 2016

Not directly related to the PR, but it would be time to update the new Beat dev guide. It's using Topbeat so this will make it even more outdated, but we'd anyway have to speak about the generator, about the single repo, etc.

OTOH, the guide doesn't really seem to be required :-).

@ruflin
Copy link
Collaborator Author

ruflin commented Mar 17, 2016

@tsg Fully agree for the Dev Guide. Needs urgently an update / restructuring. I think it needs to be less focused on the first step of creating the beat, but then how to proceed from there. What are sync / async publisher, how to use ucfg etc.

@@ -0,0 +1,19 @@
package system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if sigar.go is the best name for this file especially after you split the sigar functions into multiple dedicated files. As it contains for now only Round function, I would go for common.go and it can be considered the place for all the common system functions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed it to common.go

@monicasarbu monicasarbu mentioned this pull request Mar 18, 2016
5 tasks
@monicasarbu
Copy link
Contributor

LGTM

@monicasarbu
Copy link
Contributor

@ruflin Please rebase to master, so I can easily merge it.

Topbeat has lots of functionality which can be reused in other libraries, especially topbeat. To decouple the functionality from topbeat, this PR restructures Topbeat into the beater part and the library part. This makes is possible to reuse and share the functionality between Topbeat and Metricbeat.

Further steps should be taken later to also better split up the testing and introduce ucfg in topbeat.

This refactoring did not change any functionality or output of topbeat.
@ruflin
Copy link
Collaborator Author

ruflin commented Mar 18, 2016

@monicasarbu Rebase done and newest version pushed.

@monicasarbu
Copy link
Contributor

@ruflin Great, thanks

monicasarbu added a commit that referenced this pull request Mar 21, 2016
Restructure topbeat to make functions available as library
@monicasarbu monicasarbu merged commit e9eaddc into elastic:master Mar 21, 2016
@ruflin ruflin deleted the topbeat-library branch March 21, 2016 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants