[Metricbeat] Add remove fields option to mocked tests config#11716
Merged
sayden merged 2 commits intoApr 9, 2019
Conversation
(cherry picked from commit c402e4f52ec4d5c734eac6db1eda38552264c63a)
sayden
added
review
Metricbeat
Contributor
Author
|
@ruflin about your comment #11703 (comment), the difference is the following: I also don't have a strong preference but I thought that this approach, without the spaces in the testing output, will look nicer. The files on disk are correctly indented, of course. |
ruflin
approved these changes
Apr 9, 2019
Contributor
Author
|
Failure seems unrelated. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split PR from here #11703
Config option remove_fields_from_comparison to remove fields from the JSON generated and expected files to byte-to-byte comparison when asserting tests.