Skip to content

Filebeat envoyproxy module#11700

Merged
alakahakai merged 22 commits intoelastic:masterfrom
alakahakai:filebeat-envoy
Apr 17, 2019
Merged

Filebeat envoyproxy module#11700
alakahakai merged 22 commits intoelastic:masterfrom
alakahakai:filebeat-envoy

Conversation

@alakahakai
Copy link
Copy Markdown

@alakahakai alakahakai commented Apr 8, 2019 •
edited
Loading

Filebeat envoyproxy module:

  • Handles both Kubernetes deployment and native deployment scenarios
  • Supports both HTTP and TCP outputs

@alakahakai alakahakai requested review from a team as code owners April 8, 2019 17:03
@alakahakai alakahakai added Filebeat Filebeat module in progress Pull request is currently in progress. labels Apr 8, 2019
@alakahakai alakahakai requested a review from a team April 8, 2019 17:04
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 8, 2019

Pinging @elastic/secops

@alakahakai
Copy link
Copy Markdown
Author

alakahakai commented Apr 12, 2019

jenkins, test this

@alakahakai alakahakai added review and removed in progress Pull request is currently in progress. labels Apr 12, 2019
odacremolbap
odacremolbap reviewed Apr 12, 2019
View reviewed changes
Comment thread filebeat/docs/modules/envoyproxy.asciidoc Outdated
odacremolbap
odacremolbap reviewed Apr 12, 2019
View reviewed changes
Comment thread x-pack/filebeat/module/envoyproxy/README.md Outdated
odacremolbap
odacremolbap reviewed Apr 12, 2019
View reviewed changes
Comment thread x-pack/filebeat/module/envoyproxy/README.md Outdated
odacremolbap
odacremolbap reviewed Apr 12, 2019
View reviewed changes
Comment thread x-pack/filebeat/module/envoyproxy/README.md
@alakahakai
Copy link
Copy Markdown
Author

alakahakai commented Apr 13, 2019

jenkins, test this

1 similar comment
@alakahakai
Copy link
Copy Markdown
Author

alakahakai commented Apr 15, 2019

jenkins, test this

@alakahakai alakahakai requested review from andrewkroh and tsg April 15, 2019 15:09
andrewkroh
andrewkroh approved these changes Apr 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few minor comments.

Comment thread x-pack/filebeat/module/envoyproxy/_meta/docs.asciidoc Outdated
@alakahakai alakahakai merged commit 03e316e into elastic:master Apr 17, 2019
@alakahakai alakahakai deleted the filebeat-envoy branch April 18, 2019 16:58
@tsg tsg added needs_backport PR is waiting to be backported to other branches. and removed needs_backport PR is waiting to be backported to other branches. labels Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@tsg tsg Awaiting requested review from tsg

+1 more reviewer

@odacremolbap odacremolbap odacremolbap left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Filebeat Filebeat module review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alakahakai @elasticmachine @andrewkroh @odacremolbap @tsg