[Metricbeat] migrate nginx module to ReporterV2 error

[berfinsari]

See #11374 and #10727

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[ruflin]

jenkins, test this

[ruflin]

I think the CI failure is related. In [fail] 0.10% test_cmd.TestCommands.test_modules_test_error we use the nginx module to test the error output. With this change, it's logged now on the Info level (which I think is fine and expected) but we need to adjust the tests there.

[fearful-symmetry]

@ruflin Do we need to change whatever test harness is using the nginx moule?

[fearful-symmetry]

beats/metricbeat/tests/system/test_cmd.py

Line 141 in 6bff9a6

self.log_contains("ERROR error making http request"),

Did we just hard-code expected error values into the testing framework? The error body that's returned also seems completely different, but I could be reading the CI logs wrong.

[ruflin]

@fearful-symmetry Yes, we need to adjust these tests. For the hardcoded errors: Yes, they are there :-) I think the issue is that now the errors are on the INFO level and not ERROR level anymore.

[fearful-symmetry]

Ah, it looks like it's not a log level problem, just the addition of errors.Wrap that conflicts with what the test is looking for? We have the assert looking for:

 self.log_contains("ERROR error making http request"), 

and our new output from travis is:

ERROR error in http fetch: error making http request: Get http://errorhost:80/server-status: lookup errorhost: no such host

So the problem is just the error in http fetch

@berfinsari I think the solution is just to update test_cmd.py with the new string introduced by errors.Wrap()

[fearful-symmetry]

@berfinsari Do you still want to work on this?

[sayden]

Ping @berfinsari 🙂

Don't feel pressed. It's perfectly ok if you don't have time now, anyone else can continue with this 😉

[sayden]

Merged already in #13518

Thanks for the help anyways, @berfinsari 🙂