Change Cpu.Get() on Windows to not use floating point artimetic #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
feature/topbeat-windows-cpu-get
branch
2 times, most recently
from
2226293
to
423349c
Compare
andrewkroh
force-pushed
the
feature/topbeat-windows-cpu-get
branch
from
423349c
to
71bd823
Compare
|
Waiting for Travis on this one. It shouldn't be that long now.. |
|
Great! LGTM |
monicasarbu
added a commit
that referenced
this pull request
Mar 8, 2016
Change Cpu.Get() on Windows to not use floating point artimetic
|
It looks like this fixed the issue. We got some feedback from the user that was experiencing the problem on Windows. |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Mar 30, 2016
Backport of elastic#1128 to 1.2 - Change Cpu.Get() on Windows to not use floating point arithmetic
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Apr 6, 2016
Backport of elastic#1128 to 1.2.1
This was referenced Jun 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates elastic/gosigar#19 to hopefully fix an issue with incorrect
cpu.system_pvalues on Windows. See discussBest case: it fixes the issue
Worst case: instead of incorrect values
cpu.system_pvalues, it reports a negative percentage due to the system time value being reported as negative by Windows.