Backport #11240 to 7.0: Re-introduce field formats on ECS fields. (#11240)#11241
Merged
webmat merged 1 commit intoelastic:7.0from Mar 14, 2019
Merged
Backport #11240 to 7.0: Re-introduce field formats on ECS fields. (#11240)#11241webmat merged 1 commit intoelastic:7.0from
webmat merged 1 commit intoelastic:7.0from
Conversation
Contributor
Author
|
I'm kicking off this backport early (aka before the original is merged) because the original is trivial. Hopefully this can streamline the fixing of 7.0, if tests are all green here tomorrow morning. |
Contributor
Author
|
Error here is also in the Metricbeat testsuite around elasticsearch:6.6.0. But the errors are very different than on #11240. Will investigate tomorrow. |
Contributor
Author
|
jenkins, test this bro |
This was referenced Mar 14, 2019
Contributor
|
Same comment as for #11240, otherwise LGTM. |
Contributor
Author
They were accidentally removed by elastic#11150.
webmat
force-pushed
the
backport_11240_7.0
branch
from
58892c1 to
6a82a57
Compare
Contributor
Author
|
This is merged @simitt |
webmat
referenced
this pull request
Mar 22, 2019
Moved the definition of `agent.hostname` to fields.common.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were accidentally removed by #11150.