Skip to content

Skip flaky ES integration tests for now #11230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruflin merged 1 commit into from
Mar 14, 2019
Merged

Skip flaky ES integration tests for now #11230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metricbeat/module/elasticsearch/elasticsearch_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ var metricSets = []string{
}

func TestFetch(t *testing.T) {
t.Skip("flaky")
compose.EnsureUp(t, "elasticsearch")

host := net.JoinHostPort(getEnvHost(), getEnvPort())
Expand Down Expand Up @@ -100,6 +101,7 @@ func TestFetch(t *testing.T) {
}

func TestData(t *testing.T) {
t.Skip("flaky")
Copy link
Copy Markdown
Contributor

@ruflin ruflin Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting one. We started to remove the compose.EnsureUp in the data tests as they are skipped anyways later on. Perhaps try to also in your other PR. The idea is that we move this to the new data tests framework. Having the Stack modules there too would be great. Please ping me if you need more details.

Copy link
Copy Markdown
Contributor Author

@ycombinator ycombinator Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruflin If you could point me to a PR that shows a module moving to the new data tests framework, that would be very helpful. If it's too much trouble, I can look around in the code and try to figure it out too.

Copy link
Copy Markdown
Contributor

@ruflin ruflin Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an example: #11112 But we should probably still sync up as Elasticsearch is a bit different because it needs more then 1 endpoint available which is not supported yet (but we should add it).

compose.EnsureUp(t, "elasticsearch")

host := net.JoinHostPort(getEnvHost(), getEnvPort())
Expand Down