[Metricbeat] fix default config for mysql tests#11218
Merged
fearful-symmetry merged 1 commit intoelastic:masterfrom Mar 13, 2019
Merged
[Metricbeat] fix default config for mysql tests#11218fearful-symmetry merged 1 commit intoelastic:masterfrom
fearful-symmetry merged 1 commit intoelastic:masterfrom
Conversation
ruflin
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue I discussed in slack with @ruflin . Namely, if you run the mysql integration tests on a host environment via
go test -tags=integration, it throws an error:This is due to how we set the mysql config object when
MYSQL_DSNisn't set viadocker-composeMost other integration tests hard-code ports/hostnames in cases where a given env var isn't set, so what I've done seems fairly standard, but if anyone objects, please tell me and I can get more clever. Only other thing of note is the use of
mysql.NewConfig()which seems to be the "preferred" way of creating a new mysql config.