Fix fields.yml for sqs from message.* to messages.*#11188
Merged
kaiyan-sheng merged 4 commits intoelastic:masterfrom Mar 13, 2019
kaiyan-sheng:fix_sqs_fields
Merged
Fix fields.yml for sqs from message.* to messages.*#11188kaiyan-sheng merged 4 commits intoelastic:masterfrom kaiyan-sheng:fix_sqs_fields
kaiyan-sheng merged 4 commits intoelastic:masterfrom
kaiyan-sheng:fix_sqs_fields
Conversation
ruflin
reviewed
Mar 12, 2019
ruflin
approved these changes
Mar 12, 2019
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM
Could you update the PR title and message to be in line what we have with the PR now?
kaiyan-sheng
changed the title
Contributor
Author
|
jenkins, test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found these problems when trying to add dashboard for sqs. In fields.yml, metric names are wrong, should be
messages.*instead ofmessage.*.