Skip to content

Add NATS Filebeat dashboard#11170

Merged
ruflin merged 1 commit intoelastic:masterfrom
nfvri:nats-filebeat-dashboard
Mar 12, 2019
Merged

Add NATS Filebeat dashboard#11170
ruflin merged 1 commit intoelastic:masterfrom
nfvri:nats-filebeat-dashboard

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Mar 8, 2019

This PR is part of #10071.

Co-Authored-By: Stamatis Katsaounis katsaouniss@gmail.com
Co-Authored-By: Michael Katsoulis michaelkatsoulis88@gmail.com

@ChrsMark ChrsMark requested a review from a team as a code owner March 8, 2019 23:19
@elasticmachine
Copy link
Copy Markdown
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented Mar 8, 2019

filebeatdashboard

Cc: @skatsaounis , @MichaelKatsoulis , @ruflin

@ChrsMark ChrsMark requested a review from a team as a code owner March 10, 2019 11:51
Signed-off-by: Chris <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Copy Markdown
Member Author

Taking the opportunity to mention here that the importing procedure of Filebeat's dashboards is quite tricky. Actually I was not able to import the dashboards with make import-dashboards as I had done with Metricbeat's in the past.

In order to make it work for me I copied Metricbeat's Makefile approach, so I add the following lines in the Makefile of Filebeat:

# Collects all module dashboards
.PHONY: kibana
kibana:
       @rm -rf _meta/kibana.generated
       @mkdir -p _meta/kibana.generated
       @-cp -pr module/*/_meta/kibana/* _meta/kibana.generated

Then I run:

  1. make kibana
  2. python ../libbeat/scripts/unpack_dashboards.py --glob="./_meta/kibana.generated/7/dashboard/*.json"
  3. make import-dashboards

Is there a more solid way to achieve this? Despite I searched a lot I didn't find anything so I had to dive into the code to tackle this.

@ruflin ruflin added module Filebeat Filebeat Team:Integrations Label for the Integrations team review labels Mar 12, 2019
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Mar 12, 2019

jenkins, test this

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Mar 12, 2019

The way I test it is: ./filebeat -E setup.dashboards.directory=./build/kibana/ -e. In Filebeat the generated dashboards are under build/kibana. We plan to unify this moving forward.

Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested by loading this dashboard and skimming through the JSON. I couldn't test it with real data but looks solid to me.

@ruflin ruflin merged commit 33833be into elastic:master Mar 12, 2019
@skatsaounis
Copy link
Copy Markdown
Contributor

@ruflin: Hi Nicolas! A quick info: I found out that this PR is not part of 7.x branch. I do not know if it happens for a reason or it was mistakenly not back-ported.

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Mar 26, 2019

We do bulk backports to 7.x once a week. Seems like we didn't do one since this got merged, but it will happen soon ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Filebeat Filebeat module review Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants