[Metricbeat] Add Zookeeper connections metricset#11070
[Metricbeat] Add Zookeeper connections metricset#11070sayden merged 14 commits intoelastic:masterfrom
Conversation
sayden
added
Metricbeat
sayden
added
review
and removed
in progress
|
jenkins, test this please |
jsoriano
left a comment
jsoriano
left a comment
There was a problem hiding this comment.
Thanks for adding this new metricset!
There was a problem hiding this comment.
Is there going to be always connections available to report?
Should we keep a connection with zookeeper open here to avoid flakiness?
There was a problem hiding this comment.
I don't follow you. If you want to change the behaviour of the module or the system tests it should go in a different PR, this is just to add a Metricset with the current behaviour and Cloud is waiting for it 😉
There was a problem hiding this comment.
If there is no connection to the zookeeper service, no event is generated and then this will fail. I was wondering if we should open a connection in the test to avoid flakiness because of that.
Nothing to change in the module, just maybe in the test.
If there is always going to be a connection here because of other reasons then you can ignore my comment 🙂
There was a problem hiding this comment.
Also this, if it is not failing now I think it won't fail, to be revisited if there are related flaky tests.
sayden
added
in progress
sayden
force-pushed
the
feature/mb/zookeeper-connections-metricset
branch
from
52ce129 to
17d2111
Compare
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
Ups, forgot to hit submit after reviewing :-(
There was a problem hiding this comment.
Now they are part of ECS as requested by Jaime
| } else { | ||
| m.checkRegexAndSetInt(metricsetFields, v, k, &oneParsingIsCorrect) | ||
| } | ||
| } |
There was a problem hiding this comment.
Could schema be used here for these mappings?
There was a problem hiding this comment.
Lets leave this change for a follow up as this is blocking other things.
There was a problem hiding this comment.
Awesome, thanks Jaime!
|
|
||
| if oneParsingIsCorrect { | ||
| result = append(result, mb.Event{MetricSetFields: metricsetFields, RootFields: rootFields}) | ||
| } |
There was a problem hiding this comment.
Should we log at least at the debug level if nothing parsed correctly?
| } else { | ||
| m.checkRegexAndSetInt(metricsetFields, v, k, &oneParsingIsCorrect) | ||
| } | ||
| } |
There was a problem hiding this comment.
Lets leave this change for a follow up as this is blocking other things.
There was a problem hiding this comment.
Also this, if it is not failing now I think it won't fail, to be revisited if there are related flaky tests.
|
Error seems unrelated. Merging |
6 participants
Zookeeper connections Metricset parses the incoming information of
cons4 letter command from Zookeeper and emit a single event for each connection that appears in the output.Relates to this #10475