Change CRI-O parsing to use RFC3339Nano#10951
Change CRI-O parsing to use RFC3339Nano#10951vjsamuel wants to merge 1 commit intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@vjsamuel thanks for this! Will this continue working with docker logs? |
|
jenkins, test this |
|
Yes. This only affects Cri-o processing logic which kicks in after detecting if the log is a docker log or not. Hence docker logs are unaffected. |
|
We should probably backport this fix. |
|
any chance to add tests for this? |
|
@vjsamuel did you find a log entry that didn't work before this change and works with it? It'd be good to have a test case for this. |
|
never was able to reproduce this as it might have been misconfiguration. apologies. |
|
Facing the same issue with elastic stack version 7.5.1 My approach is - filebeats collects log and sends to logstash and from there to elasticsearch. It was working fine a day ago,in fact, 3/5 filebeat pods are still in running state, however some filebeat pods keep crashing. Can someone tell me any changes I need to do. I am on Kubernetes. And also have a nginx-controller running for the cluster |
|
Perhaps this was also related to #22685. |
CRI-O uses RFC3339Nano to generate timestamps which was causing the CRI-O based parsing to parse incorrectly. This PR attempts to fix that.