Skip to content

Change CRI-O parsing to use RFC3339Nano#10951

Closed
vjsamuel wants to merge 1 commit intoelastic:masterfrom
vjsamuel:cri-nano
Closed

Change CRI-O parsing to use RFC3339Nano#10951
vjsamuel wants to merge 1 commit intoelastic:masterfrom
vjsamuel:cri-nano

Conversation

@vjsamuel
Copy link
Copy Markdown
Contributor

CRI-O uses RFC3339Nano to generate timestamps which was causing the CRI-O based parsing to parse incorrectly. This PR attempts to fix that.

@vjsamuel vjsamuel requested a review from a team as a code owner February 26, 2019 22:45
@elasticmachine
Copy link
Copy Markdown
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jsoriano jsoriano added enhancement review Filebeat Filebeat libbeat containers Related to containers use case Team:Integrations Label for the Integrations team labels Feb 27, 2019
@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Mar 1, 2019

@vjsamuel thanks for this! Will this continue working with docker logs?

@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Mar 1, 2019

jenkins, test this

@vjsamuel
Copy link
Copy Markdown
Contributor Author

vjsamuel commented Mar 1, 2019

Yes. This only affects Cri-o processing logic which kicks in after detecting if the log is a docker log or not. Hence docker logs are unaffected.

@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Mar 1, 2019

We should probably backport this fix.

@exekias
Copy link
Copy Markdown
Contributor

exekias commented Apr 4, 2019

any chance to add tests for this?

@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented May 7, 2019

@vjsamuel did you find a log entry that didn't work before this change and works with it? It'd be good to have a test case for this.
As we couldn't reproduce this issue I am going to close this PR by now. Please feel free to reopen if you have a test case, or some other confirmation of this fixing the issue you were having.
Thanks!

@jsoriano jsoriano closed this May 7, 2019
@vjsamuel
Copy link
Copy Markdown
Contributor Author

never was able to reproduce this as it might have been misconfiguration. apologies.

@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Jun 28, 2019
@shishirkh
Copy link
Copy Markdown

Facing the same issue with elastic stack version 7.5.1

2020-12-21T07:13:00.894Z ERROR readjson/docker_json.go:201 Parse line error: parsing CRI timestamp: parsing time "{"log":"reading" as "2006-01-02T15:04:05.999999999Z07:00": cannot parse "{"log":"reading" as "2006"

My approach is - filebeats collects log and sends to logstash and from there to elasticsearch. It was working fine a day ago,in fact, 3/5 filebeat pods are still in running state, however some filebeat pods keep crashing. Can someone tell me any changes I need to do. I am on Kubernetes. And also have a nginx-controller running for the cluster

@shishirkh
Copy link
Copy Markdown

@jsoriano @vjsamuel

@jsoriano
Copy link
Copy Markdown
Member

Perhaps this was also related to #22685.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

containers Related to containers use case enhancement Filebeat Filebeat libbeat review Team:Integrations Label for the Integrations team v6.6.2 v6.7.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants