Cherry-pick #10592 to 6.x: Update and add missing descriptions to ETCD module#10611
Cherry-pick #10592 to 6.x: Update and add missing descriptions to ETCD module#10611sayden merged 1 commit intoelastic:6.7from
Conversation
(cherry picked from commit da2c258) # Conflicts: # metricbeat/docs/fields.asciidoc # metricbeat/module/etcd/fields.go
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM
Can you update the description of the PR so it only contains what actually changed? Otherwise someone opening this PR could be confused what made it into it and what not. Updating can also be done after merging.
|
Please backport to 6.7 branch. 6.x will be removed. |
|
@sayden Could you try to adjust the branch this PR tragets? Github has now such a setting. I wonder if this works. |
|
I changed base to 6.7 |
|
jenkins, test this |
|
jenkins, test this again, please |
|
jenkins, test this again, please |
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM. For the CI failure, looks like it's heartbeat: https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/4920/beat=heartbeat,label=linux-immutable/console
@sayden Could you open a follow up issue with the flaky test description and a PR to skip this test? This PR here can already be merged.
@andrewvc FYI
|
Issue opened here #10722 |
3 participants
Cherry-pick of PR #10592 to 6.x branch. Original message:
Fixes #10239 and adds some missing descriptions on:
leader.followers.counts.successleader.followers.counts.failleader.leader