Skip to content

Cherry-pick #10592 to 6.x: Update and add missing descriptions to ETCD module #10611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sayden merged 1 commit into from
Feb 13, 2019
Merged

Cherry-pick #10592 to 6.x: Update and add missing descriptions to ETCD module #10611

sayden merged 1 commit into from
Feb 13, 2019

Conversation

@sayden
Copy link
Contributor

@sayden sayden commented Feb 6, 2019 •
edited
Loading

Cherry-pick of PR #10592 to 6.x branch. Original message:

Fixes #10239 and adds some missing descriptions on:

  • leader.followers.counts.success
  • leader.followers.counts.fail
  • leader.leader

@sayden
Update and add missing descriptions to ETCD module (elastic#10592)
c57be60 
(cherry picked from commit da2c258)

# Conflicts:
#	metricbeat/docs/fields.asciidoc
#	metricbeat/module/etcd/fields.go
ruflin
ruflin approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you update the description of the PR so it only contains what actually changed? Otherwise someone opening this PR could be confused what made it into it and what not. Updating can also be done after merging.

@urso
Copy link

urso commented Feb 6, 2019

Please backport to 6.7 branch. 6.x will be removed.

@ruflin
Copy link
Contributor

ruflin commented Feb 6, 2019

@sayden Could you try to adjust the branch this PR tragets? Github has now such a setting. I wonder if this works.

@urso urso changed the base branch from 6.x to 6.7 February 6, 2019 13:41
@urso
Copy link

urso commented Feb 6, 2019

I changed base to 6.7

@sayden
Copy link
Contributor Author

sayden commented Feb 6, 2019

jenkins, test this

@sayden
Copy link
Contributor Author

sayden commented Feb 6, 2019

jenkins, test this again, please

@sayden sayden self-assigned this Feb 7, 2019
@sayden sayden added the Team:Integrations Label for the Integrations team label Feb 11, 2019
@sayden
Copy link
Contributor Author

sayden commented Feb 11, 2019

jenkins, test this again, please

ruflin
ruflin approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For the CI failure, looks like it's heartbeat: https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/4920/beat=heartbeat,label=linux-immutable/console

@sayden Could you open a follow up issue with the flaky test description and a PR to skip this test? This PR here can already be merged.

@andrewvc FYI

@sayden sayden mentioned this pull request Feb 13, 2019
Closed
@sayden
Copy link
Contributor Author

sayden commented Feb 13, 2019

Issue opened here #10722

@sayden sayden merged commit 1c1ffcb into elastic:6.7 Feb 13, 2019
@sayden sayden deleted the backport_10592_6.x branch October 29, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@sayden sayden

Labels

backport review Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayden @urso @ruflin