Update filebeat registry configuration#10504
Conversation
There was a problem hiding this comment.
exported type Registry should have comment or be unexported
|
Jenkins, test this. |
|
As the new registry is a libbeat feature, should the config be prefixed by filebeat or not? |
I'm thinking the same. It's a little ugly though. Filebeat itself needs to install the registry with the publisher pipeline, but filebeat does not have access to the root configuration (without introducing even more hacks). The core functionality will be provided by libbeat. This is basically a kvstore interface. but the actual registrar will stay in filebeat as well, as the registrar is very much coupled with the log input. Out of the box integration of registry with publisher pipeline and required refactorings in filebeat is more likely a 8.0 target. |
b9d7456 to
2715af6
Compare
|
@urso good looks good and thanks for taking care of updating the doc, the failures on the CI are maybe related, they all look to be a synchronization issue. |
|
fixed filebeat tests. Was another rebase error. |
Change registry config and directory layout, preparing for future
changes.
- remove settings `filebeat.registry_file` and replace with
`filebeat.registry.path`. Path will be a directory, and the
actual contents will be stored under
`${filebeat.registry.path}/filebeat/data.json`.
- introduce `<registry path>/filebeat/meta.json` with version number of
the current directories layout.
- move `filebeat.registry_flush` to `filebeat.registry.flush`
- move `filebeat.registry_file_permission` to
`filebeat.registry.file_permission`
- update tests
The registry path changed in elastic/beats#10504.
The registry path changed in elastic/beats#10504.
Change registry config and directory layout, preparing for future
changes.
filebeat.registry_fileand replace withfilebeat.registry.path. Path will be a directory, and theactual contents will be stored under
${filebeat.registry.path}/filebeat/data.json.<registry path>/filebeat/meta.jsonwith version number ofthe current directories layout.
filebeat.registry_flushtofilebeat.registry.flushfilebeat.registry_file_permissiontofilebeat.registry.file_permissionThis PR introduces breaking changes now, so to reduce the impact for when we introduce the new registry format.
Note: I did keep the registry settings under
filebeat.registry, but I'm still considering to change to top-level settingregistry, as the future registry might become interesting for some auditbeat use-cases as well.