Cherry-pick #10429 to 6.x: Add rpm packaging rebase#10490
Closed
tsg wants to merge 2 commits intoelastic:6.7from
Closed
Cherry-pick #10429 to 6.x: Add rpm packaging rebase#10490tsg wants to merge 2 commits intoelastic:6.7from
tsg wants to merge 2 commits intoelastic:6.7from
Conversation
* Add RPM packages support to the package dataset (cherry picked from commit 99d09ea)
houndci-bot
reviewed
Feb 1, 2019
Contributor
Author
|
This looks green, just the filebeat tests didn't run on Jennkins for some reason. @cwurm can you give it a quick review. |
|
Please backport to 6.7 branch. 6.x will be removed. |
|
I changed base to 6.7 |
Contributor
Author
|
jenkins, test this |
Contributor
Author
|
I reopened this as #10623, because weird things happened after changing the base, and I want to make sure it's clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #10429 to 6.x branch. Original message:
This takes over the code from #9092 and rebases it on top of master.
This adds support for programmatically reading the list of RPM packages. The previous version was using exec (called the rpm binary), but we'd like to keep Auditbeat exec free, because execs are currently blocked by seccomp, as a security feature.
Using the model from Journalbeat, the new code uses dlopen get the relevant C functions and calls them using CGo. This means that librpm is not a hard dependency, but only for when this functionality is needed.