Ingest structured ES deprecation logs#10445
Merged
ycombinator merged 4 commits intoelastic:masterfrom Feb 1, 2019
ycombinator:fb-es-deprecation-structured
Merged
Ingest structured ES deprecation logs#10445ycombinator merged 4 commits intoelastic:masterfrom ycombinator:fb-es-deprecation-structured
ycombinator merged 4 commits intoelastic:masterfrom
ycombinator:fb-es-deprecation-structured
Conversation
ycombinator
added
enhancement
module
review
Filebeat
Contributor
|
Pinging @elastic/stack-monitoring |
Contributor
Author
|
/cc @pgomulka for awareness |
ruflin
reviewed
Jan 31, 2019
filebeat/module/elasticsearch/deprecation/test/elasticsearch_deprecation.log-expected.json
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ruflin Rebased and addressed review feedback. Ready for another pass, when you have a chance. Thanks! |
ruflin
approved these changes
Feb 1, 2019
cachedout
approved these changes
Feb 1, 2019
Contributor
Author
|
jenkins, test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR teaches the
elasticsearch/deprecationfileset to ingest structured Elasticsearch deprecation logs.This PR takes the same approach as #10352, in that it creates an entrypoint pipeline,
pipeline.json, that delegates further processing of a log entry depending on what it sees as the first character of the entry:{, it assumes the log line is structured as JSON and delegates further processing topipeline-json.json.pipeline-plaintext.json.