Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default APM server_url to 'http://127.0.0.1:8200' to avoid IPv6 ambiguity #727

Merged
merged 1 commit into from
Dec 13, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specs/agents/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Also known as "central configuration". Agents can query the APM Server for confi

Agents should poll the APM Server for config periodically by sending an HTTP request to the `/config/v1/agents` endpoint. Agents must specify their service name, and optionally environment. The server will use these to filter the configuration down to the relevant service and environment. There are two methods for sending these parameters:

1. Using the `GET` method, pass them as query parameters: `http://localhost:8200/config/v1/agents?service.name=opbeans&service.environment=production`
1. Using the `GET` method, pass them as query parameters: `http://127.0.0.1:8200/config/v1/agents?service.name=opbeans&service.environment=production`
2. Using the `POST` method, encode the parameters as a JSON object in the body, e.g. `{"service": {"name": "opbeans", "environment": "production"}}`

The server will respond with a JSON object, where each key maps a config attribute to a string value. The string value should be interpreted the same as if it were passed in via an environment variable. Upon receiving these config changes, the agent will update its configuration dynamically, overriding any config previously specified. That is, config via Kibana takes highest precedence.
Expand Down Expand Up @@ -139,7 +139,7 @@ To decrease onboarding friction,
APM agents MUST not require any configuration to send data to a local APM Server.
After onboarding, users can customize settings for which the defaults aren't appropriate.

By default, agents MUST send data to the APM Server at `http://localhost:8200/`.
By default, agents MUST send data to the APM Server at `http://127.0.0.1:8200/`.
If possible, agents SHOULD detect sensible defaults for `service.name` and `service.version`.
In any case agents MUST include `service.name` - if discovering it is not possible then the default value: `unknown-${service.agent.name}-service` MUST be used.
This naming pattern allows the UI to display inline help on how to manually configure the name.
Expand Down