Enable transaction aggregation by default#4882
Merged
axw merged 5 commits intoelastic:masterfrom Mar 3, 2021
Merged
Conversation
Enable by default so the UI can set the metrics-based mode to auto or on by default. We still don't drop unsampled transactions by default.
axw
force-pushed
the
txmetrics-enabled-default
branch
from
24808e5 to
d6ec9a0
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Codecov Report
@@ Coverage Diff @@
## master #4882 +/- ##
==========================================
+ Coverage 76.56% 76.62% +0.06%
==========================================
Files 166 166
Lines 10134 10135 +1
==========================================
+ Hits 7759 7766 +7
+ Misses 2375 2369 -6
|
Member
Author
|
System test failure is unrelated, will be fixed by #4883 |
Member
Author
|
jenkins run the tests please |
jalvz
approved these changes
Mar 3, 2021
axw
added a commit
to axw/apm-server
that referenced
this pull request
Mar 25, 2021
Enable by default so the UI can set the metrics-based mode to auto or on by default. We still don't drop unsampled transactions by default. # Conflicts: # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Mar 25, 2021
Enable by default so the UI can set the metrics-based mode to auto or on by default. We still don't drop unsampled transactions by default. # Conflicts: # changelogs/head.asciidoc Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify Bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
Enable by default so the UI can set the metrics-based mode to auto or on by default. We still don't drop unsampled transactions by default. (cherry picked from commit 41c47d1) # Conflicts: # changelogs/head.asciidoc
Contributor
|
Works as expected with latest BC and integration testing, eg: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Enable by default so the UI can set the metrics-based mode to auto or on by default.
We still don't drop unsampled transactions by default.
Checklist
- [ ] Documentation has been updatedthere are currently no docs for this feature.How to test these changes
transaction.duration.histogram)Related issues
Closes #4816