Skip to content

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Oct 22, 2020

Summary

Alphabetizes the config reference and adds reference docs for transaction metrics.

For a number of good reasons, this is still opt-in. How much do we want to publicize this? Better worded: do we need more than just reference documentation for this feature yet?

Related issues

Closes #4031

@bmorelli25 bmorelli25 requested a review from axw October 22, 2020 22:08
@bmorelli25 bmorelli25 self-assigned this Oct 22, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4345 updated]

  • Start Time: 2020-11-02T21:25:14.589+0000

  • Duration: 7 min 6 sec

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


[[sampling-keep_unsampled]]
[float]
==== `keep_unsampled`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should document this one. I think this will end up going away in favour of the updating the agents to stop sending unsampled transactions. Also, I suspect this config might be incompatible with RUM/User Experience monitoring, where we probably want to record individual requests without a full sampled trace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do remove this config from the docs, do the apm-server.aggregation.transactions.* configs still result in storage reduction? I want to make sure your previous suggested change still holds true if we remove this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh good point. Indeed, storage reduction relies on us discarding the unsampled transaction docs.
I guess we should keep it then, and just mark it as experimental.

@dgieselaar
Copy link
Member

This feature is also opt-in in Kibana. Do we need docs for that as well?

@bmorelli25
Copy link
Member Author

This feature is also opt-in in Kibana. Do we need docs for that as well?

Yes. Is it xpack.apm.searchAggregatedTransactions? I can add a note to these docs with a link to https://www.elastic.co/guide/en/kibana/current/apm-settings-in-kibana.html and vice versa.

Also, question: When I enable this, how do I know that it's working? What can I look for?

@axw
Copy link
Member

axw commented Nov 2, 2020

Also, question: When I enable this, how do I know that it's working? What can I look for?

With the example config

apm-server:
  aggregation:
    transactions:
      enabled: true
      interval: 1m
  sampling:
    keep_unsampled: false

Configure the agent to sample, and you should end up with a distribution chart that looks roughly correct. If Kibana were not configured with searchAggregatedTransactions, then the charts would show numbers based on only the sampled transactions.

@bmorelli25
Copy link
Member Author

bmorelli25 commented Nov 2, 2020

Perfect. Thanks for your help, @axw.

Kib PR: elastic/kibana#82379

@bmorelli25 bmorelli25 merged commit c7f55b0 into elastic:master Nov 2, 2020
@bmorelli25 bmorelli25 deleted the doc-transaction-metrics branch November 2, 2020 22:09
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Nov 2, 2020
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Nov 2, 2020
bmorelli25 added a commit that referenced this pull request Nov 3, 2020
bmorelli25 added a commit that referenced this pull request Nov 3, 2020
@cyrille-leclerc
Copy link
Contributor

@bmorelli25 I searched how to create a graph from Transaction as Histograms and didn't find the docs searching on Google. Do we have an SEO question here?

@bmorelli25
Copy link
Member Author

bmorelli25 commented Dec 6, 2021

@bmorelli25 I searched how to create a graph from Transaction as Histograms and didn't find the docs searching on Google. Do we have an SEO question here?

@cyrille-leclerc That's a result of only adding reference documentation for this feature. There's no how-to guide with a Googlable H1. This plays into the thread on Slack... Would you mind opening an issue?

@cyrille-leclerc
Copy link
Contributor

cyrille-leclerc commented Dec 8, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document transaction metrics

4 participants