add span reparenting field child_ids#3679
Merged
graphaelli merged 7 commits intoelastic:masterfrom Apr 22, 2020
Merged
Conversation
Member
Author
|
Even though it was in the proposal, I'm not sure about |
Member
Author
|
Good call. I pushed the change to |
simitt
approved these changes
Apr 22, 2020
Contributor
simitt
left a comment
There was a problem hiding this comment.
IMO child is the right term here. What makes it confusing is that parent now doesn't actually mean parent anymore but can refer to any predecessor. A child's event can have another parent, that breaks my parent/child logic. Since parent.id is used for the waterfall UI (afaik) I don't think we could easily change that though, so LGTM.
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Apr 23, 2020
graphaelli
added a commit
that referenced
this pull request
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Span reparenting intake. Closes #3422
Checklist
make check-fullfor static code checks and linting)How to test these changes
Related issues