chore: fetch all remotes before to checkout the branch#3228
Merged
kuisathaverat merged 1 commit intoelastic:masterfrom Jan 23, 2020
Merged
chore: fetch all remotes before to checkout the branch#3228kuisathaverat merged 1 commit intoelastic:masterfrom
kuisathaverat merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Can you please rebase on master, the failing test should be fixed. |
Contributor
Author
|
@simitt it does not need to make a rebase we make a merge before the build, so it is a matter of rebuild it |
simitt
approved these changes
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a
git fetch --allbefore to checkout the Beats branch.Why is it important?
It allows us to use commits for any branch or remote ref that we have configured in our
gitconfig as Beats version (e.g commit PRs using the git ref +refs/pull//head:refs/remotes/origin/pr/)Related issues
related to elastic/beats#15631 and elastic/beats#13371