[docs] Add and improve SSL/TLS documentation#2715
Conversation
|
Thank you @bmorelli25! A few preliminary thoughts:
Are those fixable, or are they the things for which we're at the mercy of Beats? I'm not 100% on this, but would it be better if "SSL output settings" and "SSL input settings" were under "Configuring APM Server", since they're fairly low-level descriptions of the config attributes? That would leave "Securing APM Server" for higher level guides. We could then cross-reference them. |
I'm not sure why Beats chose this naming convention. You're right that it doesn't fit with the other two. I'll propose the change in Beats!
This is a good point. My thought process was that having everything under the securing section would make the most sense -- one stop shopping if you will. But you're right, with the heading levels it is a bit confusing to figure out where to start. Let me try moving these two files to the "Configuring APM Server" section and we can see how that looks. |
|
Actually, that was a pretty easy move since I already understood the complexities. I've updated the description of this PR to include the new layout. I even got to use |
|
Not directly part of this PR but in Securing Communication With Elasticsearch there is this sentence:
It is hard to understand for APM Server as the mentioned server is the one APM Server talks to. I suggest to change Beat to APM Server:
|
axw
left a comment
There was a problem hiding this comment.
I find this structure much easier to navigate - thank you.
|
Thanks for the feedback @axw and @simitt! Silvia, sorry, a lot of those were dumb mistakes. Thanks for catching them 😇. I have one clarifying question above.
Good spot -- updated to |
simitt
left a comment
There was a problem hiding this comment.
Looks great! Once again - really like the new docs structure you build here.
axw
left a comment
There was a problem hiding this comment.
Thank you, this is a great improvement :)
|
jenkins, run tests again please |
|
@elasticmachine, run elasticsearch-ci/docs rebuild |
|
jenkins, run tests again please |
|
Added to elastic/beats#13596 to persist the shared changes in the Beats repo. |
Closes #1579.
A preview of the changes made in this PR is available here.
I'm beginning to remember why this issue has been open for almost a year. We are at the mercy of Beats formatting of the
Securing {beatname_uc}section. I'm not sure these changes would've been possible before Asciidoctor.This PR adds quite a bit of complexity to the shared Beats files. It's unfortunate, but we've needed this documentation for a long time, so it's probably necessary.
The proposed layout is:
Changes in this PR also need to be persisted in the Beats repo.