-
Notifications
You must be signed in to change notification settings - Fork 537
feat: replace apmelasticsearch with otel tracing #19386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
replace go agent apmelasticsearch module with otel replace go agent apmtest with otel manualreader in tests set span attributes to ensure span type is set in kibana
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
💚 Build Succeeded
|
| headerValue := FormatTraceparentHeader(traceContext) | ||
| req.Header[W3CTraceparentHeader] = []string{headerValue} | ||
| if tracestate := traceContext.TraceState().String(); tracestate != "" { | ||
| req.Header[TracestateHeader] = []string{tracestate} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the OTel's propogator API to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, can you expand on this ? I'm not sure how this would work (keep in mind we're not using upstream otel tracer (yet) but the apmotel abstraction in the go agent)
Motivation/summary
replace go agent apmelasticsearch module with otel
replace go agent apmtest with otel manualreader in tests
set span attributes to ensure span type is set in kibana
Checklist
For functional changes, consider:
How to test these changes
Related issues
Closes #18949