Skip to content

Conversation

@kruskall
Copy link
Member

Motivation/summary

replace go agent apmelasticsearch module with otel

replace go agent apmtest with otel manualreader in tests

set span attributes to ensure span type is set in kibana

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Closes #18949

replace go agent apmelasticsearch module with otel

replace go agent apmtest with otel manualreader in tests

set span attributes to ensure span type is set in kibana
@kruskall kruskall requested a review from a team as a code owner October 29, 2025 23:20
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Comment on lines +82 to +86
headerValue := FormatTraceparentHeader(traceContext)
req.Header[W3CTraceparentHeader] = []string{headerValue}
if tracestate := traceContext.TraceState().String(); tracestate != "" {
req.Header[TracestateHeader] = []string{tracestate}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the OTel's propogator API to do this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can you expand on this ? I'm not sure how this would work (keep in mind we're not using upstream otel tracer (yet) but the apmotel abstraction in the go agent)

@kruskall kruskall requested review from a team and lahsivjar November 6, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace apmelasticsearch with otel

3 participants