automate conflicting libbeat field removals #1665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jalvz I expect you're doing one more beats update on 6.x - you will want this in place before doing that, assuming it's acceptable. |
simitt
approved these changes
Dec 19, 2018
Contributor
|
Thanks @graphaelli ! |
Member
Author
|
great catch, thanks @jalvz |
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Jan 16, 2019
This reverts commit 02a5147.
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Jan 16, 2019
This reverts commit 02a5147.
graphaelli
added a commit
that referenced
this pull request
Jan 16, 2019
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Jan 16, 2019
* remove APM ECS comptability aliases * Revert "don't migrate beat.hostname" This reverts commit 8d8b859. * Revert "automate conflicting libbeat field removals (elastic#1665)" This reverts commit 02a5147. * revert fmt update
graphaelli
added a commit
that referenced
this pull request
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path of least resistance to get this done. Also attempted to move all of these out of libbeat and into each beat's fields.common.yml but the generated documentation ended up all wrong.