Skip to content

vendor apm-server tools needed for make check/fmt #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2018
Merged

vendor apm-server tools needed for make check/fmt #1581

merged 2 commits into from
Nov 26, 2018

Conversation

@graphaelli
Copy link
Member

@graphaelli graphaelli commented Nov 26, 2018 •
edited
Loading

  • avoid suddenly having beats on gopath following make fmt or check
  • pin versions for situations like now where apm-server is on go 1.10.3 and beats has already updated to go 1.11.2 - goimports results varying with both the go and the goimports versions

@graphaelli graphaelli changed the title vendor/use apm-server tools needed for make check/fmt vendorapm-server tools needed for make check/fmt Nov 26, 2018
@graphaelli graphaelli changed the title vendorapm-server tools needed for make check/fmt vendor apm-server tools needed for make check/fmt Nov 26, 2018
@graphaelli graphaelli requested a review from jalvz November 26, 2018 18:56
@graphaelli graphaelli mentioned this pull request Nov 26, 2018
Merged
@graphaelli graphaelli merged commit 856d8d2 into elastic:master Nov 26, 2018
@graphaelli graphaelli deleted the no-beats branch November 26, 2018 20:24
graphaelli added a commit to graphaelli/apm-server that referenced this pull request Nov 27, 2018
@graphaelli
vendor apm-server tools needed for make check/fmt (elastic#1581)
a3c6fc9
@graphaelli graphaelli mentioned this pull request Nov 27, 2018
Merged
graphaelli added a commit that referenced this pull request Nov 27, 2018
@graphaelli
vendor apm-server tools needed for make check/fmt (#1581) (#1587)
b15a8e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jalvz jalvz jalvz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@graphaelli @jalvz