[WIP] Map ECS fields #1540
Closed
[WIP] Map ECS fields #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simitt
reviewed
Nov 20, 2018
Contributor
simitt
left a comment
simitt
left a comment
There was a problem hiding this comment.
With ECS an event is going to be introduced, see https://github.com/elastic/apm-server/pull/1567/files#diff-ce180526ea1699ae1e7fa8fef38da544R335. While this mainly defines meta information about events, we do call transactions, spans, errors, metricsets events in APM. Any thoughts on how we are going to align with this?
Contributor
|
@simitt Everything from an ECS perspective is an event so I would think this is well aligned. Perhaps |
Member
Author
|
Per discussion, closing this and recreating directly against 6.x. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces mappings to preview the data model to be used in the next major release.