Skip to content

ci: use ephemeral tokens instead of APM_SERVER_RELEASE_TOKEN #14217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
v1v merged 1 commit into from
Oct 1, 2024
Merged

ci: use ephemeral tokens instead of APM_SERVER_RELEASE_TOKEN #14217

v1v merged 1 commit into from
Oct 1, 2024

Conversation

@v1v
Copy link
Member

@v1v v1v commented Oct 1, 2024

Motivation/summary

Use ephemeral tokens , similarly done in #14010

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@v1v v1v added backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.15 Automated backport with mergify backport-8.x Automated backport to the 8.x branch with mergify labels Oct 1, 2024
@v1v v1v requested a review from a team October 1, 2024 09:00
@v1v v1v self-assigned this Oct 1, 2024
@v1v v1v requested a review from a team as a code owner October 1, 2024 09:00
@v1v v1v enabled auto-merge (squash) October 1, 2024 09:46
@v1v v1v changed the title ci: use ephemeral tokens ci: use ephemeral tokens instead of APM_SERVER_RELEASE_TOKEN Oct 1, 2024
@v1v v1v merged commit 8e1eb29 into elastic:main Oct 1, 2024
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@v1v @mergify
ci: use ephemeral tokens (#14217)
d7de5b2 
(cherry picked from commit 8e1eb29)

# Conflicts:
#	.github/workflows/run-minor-release.yml
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@v1v @mergify
ci: use ephemeral tokens (#14217)
aa36cb9 
(cherry picked from commit 8e1eb29)
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@v1v @mergify
ci: use ephemeral tokens (#14217)
56537ff 
(cherry picked from commit 8e1eb29)
This was referenced Oct 1, 2024
Merged
Merged
Merged
mergify bot added a commit that referenced this pull request Oct 1, 2024
@mergify @v1v
ci: use ephemeral tokens (#14217) (#14219)
3792b82 
(cherry picked from commit 8e1eb29)

Co-authored-by: Victor Martinez <[email protected]>
mergify bot added a commit that referenced this pull request Oct 1, 2024
@mergify @v1v
ci: use ephemeral tokens (#14217) (#14220)
495251e 
(cherry picked from commit 8e1eb29)

Co-authored-by: Victor Martinez <[email protected]>
mergify bot added a commit that referenced this pull request Oct 1, 2024
@mergify @v1v
[7.17] ci: use ephemeral tokens instead of APM_SERVER_RELEASE_TOKEN (…
50f7378 
…backport #14217) (#14218)

* ci: use ephemeral tokens (#14217)

(cherry picked from commit 8e1eb29)

# Conflicts:
#	.github/workflows/run-minor-release.yml

* Apply suggestions from code review

---------

Co-authored-by: Victor Martinez <[email protected]>
leehinman pushed a commit to leehinman/apm-server that referenced this pull request Oct 1, 2024
@v1v @leehinman
ci: use ephemeral tokens (elastic#14217)
7fbb432
kruskall added a commit that referenced this pull request Oct 1, 2024
@leehinman @kruskall
@dependabot @v1v @github-actions
add flag.Parse so HandlFlags works correctly (#14214)
7efa6d5 
* add flag.Parse so HandlFlags works correctly

* fix: move flag init outside package initialization

Since go 1.13 testing flags are now only registered when running
a test binary, and packages that call flag.Parse during package
initialization may cause tests to fail.

To resolve this move the flag init to a proper function outside of
package init and call it explicitly

* build(deps): bump the dependencies group in /systemtest with 2 updates (#14213)

Bumps the dependencies group in /systemtest with 2 updates: [go.opentelemetry.io/collector/pdata](https://github.com/open-telemetry/opentelemetry-collector) and [go.opentelemetry.io/collector/semconv](https://github.com/open-telemetry/opentelemetry-collector).


Updates `go.opentelemetry.io/collector/pdata` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md)
- [Commits](open-telemetry/opentelemetry-collector@pdata/v1.15.0...pdata/v1.16.0)

Updates `go.opentelemetry.io/collector/semconv` from 0.109.0 to 0.110.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md)
- [Commits](open-telemetry/opentelemetry-collector@v0.109.0...v0.110.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/collector/pdata
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: go.opentelemetry.io/collector/semconv
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump go.elastic.co/go-licence-detector (#14212)

Bumps the dependencies group in /tools with 1 update: [go.elastic.co/go-licence-detector](https://github.com/elastic/go-licence-detector).


Updates `go.elastic.co/go-licence-detector` from 0.6.1 to 0.7.0
- [Release notes](https://github.com/elastic/go-licence-detector/releases)
- [Commits](elastic/go-licence-detector@v0.6.1...v0.7.0)

---
updated-dependencies:
- dependency-name: go.elastic.co/go-licence-detector
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kruskall <[email protected]>

* ci: use ephemeral tokens (#14217)

* build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.2 to 0.11.3 (#14211)

* build(deps): bump github.com/elastic/elastic-agent-system-metrics

Bumps [github.com/elastic/elastic-agent-system-metrics](https://github.com/elastic/elastic-agent-system-metrics) from 0.11.2 to 0.11.3.
- [Release notes](https://github.com/elastic/elastic-agent-system-metrics/releases)
- [Commits](elastic/elastic-agent-system-metrics@v0.11.2...v0.11.3)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-agent-system-metrics
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update NOTICE.txt

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: kruskall <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: kruskal <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Victor Martinez <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@leehinman @kruskall
@dependabot @v1v @github-actions @mergify
add flag.Parse so HandlFlags works correctly (#14214)
f4e98a6 
* add flag.Parse so HandlFlags works correctly

* fix: move flag init outside package initialization

Since go 1.13 testing flags are now only registered when running
a test binary, and packages that call flag.Parse during package
initialization may cause tests to fail.

To resolve this move the flag init to a proper function outside of
package init and call it explicitly

* build(deps): bump the dependencies group in /systemtest with 2 updates (#14213)

Bumps the dependencies group in /systemtest with 2 updates: [go.opentelemetry.io/collector/pdata](https://github.com/open-telemetry/opentelemetry-collector) and [go.opentelemetry.io/collector/semconv](https://github.com/open-telemetry/opentelemetry-collector).

Updates `go.opentelemetry.io/collector/pdata` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md)
- [Commits](open-telemetry/opentelemetry-collector@pdata/v1.15.0...pdata/v1.16.0)

Updates `go.opentelemetry.io/collector/semconv` from 0.109.0 to 0.110.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md)
- [Commits](open-telemetry/opentelemetry-collector@v0.109.0...v0.110.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/collector/pdata
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: go.opentelemetry.io/collector/semconv
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump go.elastic.co/go-licence-detector (#14212)

Bumps the dependencies group in /tools with 1 update: [go.elastic.co/go-licence-detector](https://github.com/elastic/go-licence-detector).

Updates `go.elastic.co/go-licence-detector` from 0.6.1 to 0.7.0
- [Release notes](https://github.com/elastic/go-licence-detector/releases)
- [Commits](elastic/go-licence-detector@v0.6.1...v0.7.0)

---
updated-dependencies:
- dependency-name: go.elastic.co/go-licence-detector
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kruskall <[email protected]>

* ci: use ephemeral tokens (#14217)

* build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.2 to 0.11.3 (#14211)

* build(deps): bump github.com/elastic/elastic-agent-system-metrics

Bumps [github.com/elastic/elastic-agent-system-metrics](https://github.com/elastic/elastic-agent-system-metrics) from 0.11.2 to 0.11.3.
- [Release notes](https://github.com/elastic/elastic-agent-system-metrics/releases)
- [Commits](elastic/elastic-agent-system-metrics@v0.11.2...v0.11.3)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-agent-system-metrics
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update NOTICE.txt

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: kruskall <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: kruskal <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Victor Martinez <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 7efa6d5)
mergify bot added a commit that referenced this pull request Oct 1, 2024
@mergify @leehinman
add flag.Parse so HandlFlags works correctly (#14214) (#14225)
3484778 
* add flag.Parse so HandlFlags works correctly

* fix: move flag init outside package initialization

Since go 1.13 testing flags are now only registered when running
a test binary, and packages that call flag.Parse during package
initialization may cause tests to fail.

To resolve this move the flag init to a proper function outside of
package init and call it explicitly

* build(deps): bump the dependencies group in /systemtest with 2 updates (#14213)

Bumps the dependencies group in /systemtest with 2 updates: [go.opentelemetry.io/collector/pdata](https://github.com/open-telemetry/opentelemetry-collector) and [go.opentelemetry.io/collector/semconv](https://github.com/open-telemetry/opentelemetry-collector).

Updates `go.opentelemetry.io/collector/pdata` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md)
- [Commits](open-telemetry/opentelemetry-collector@pdata/v1.15.0...pdata/v1.16.0)

Updates `go.opentelemetry.io/collector/semconv` from 0.109.0 to 0.110.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md)
- [Commits](open-telemetry/opentelemetry-collector@v0.109.0...v0.110.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/collector/pdata
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: go.opentelemetry.io/collector/semconv
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump go.elastic.co/go-licence-detector (#14212)

Bumps the dependencies group in /tools with 1 update: [go.elastic.co/go-licence-detector](https://github.com/elastic/go-licence-detector).

Updates `go.elastic.co/go-licence-detector` from 0.6.1 to 0.7.0
- [Release notes](https://github.com/elastic/go-licence-detector/releases)
- [Commits](elastic/go-licence-detector@v0.6.1...v0.7.0)

---
updated-dependencies:
- dependency-name: go.elastic.co/go-licence-detector
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kruskall <[email protected]>

* ci: use ephemeral tokens (#14217)

* build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.2 to 0.11.3 (#14211)

* build(deps): bump github.com/elastic/elastic-agent-system-metrics

Bumps [github.com/elastic/elastic-agent-system-metrics](https://github.com/elastic/elastic-agent-system-metrics) from 0.11.2 to 0.11.3.
- [Release notes](https://github.com/elastic/elastic-agent-system-metrics/releases)
- [Commits](elastic/elastic-agent-system-metrics@v0.11.2...v0.11.3)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-agent-system-metrics
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update NOTICE.txt

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: kruskall <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: kruskal <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Victor Martinez <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 7efa6d5)

Co-authored-by: Lee E Hinman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kruskall kruskall kruskall approved these changes

+1 more reviewer

@reakaleek reakaleek reakaleek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport with mergify

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v1v @reakaleek @kruskall