Skip to content

docs: Update exploring data in {es}#10814

Merged
bmorelli25 merged 5 commits intoelastic:mainfrom
bmorelli25:ft-explore
May 16, 2023
Merged

docs: Update exploring data in {es}#10814
bmorelli25 merged 5 commits intoelastic:mainfrom
bmorelli25:ft-explore

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented May 16, 2023

Summary

This PR moves the "Exploring data in Elasticsearch" section to the "Manage storage" bucket. It also condenses some of the content into a single page within expandable boxes.

Screenshot 2023-05-15 at 10 27 17 PM

"Application metrics" being a sub-nested heading was the best solution I could think of. Open to other ideas.

@bmorelli25 bmorelli25 requested review from a team and simitt May 16, 2023 05:28
@bmorelli25 bmorelli25 self-assigned this May 16, 2023
@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

This pull request does not have a backport label. Could you fix it @bmorelli25? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 16, 2023
@ghost
Copy link

ghost commented May 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-16T20:43:06.432+0000

  • Duration: 2 min 16 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

++++
<titleabbrev>Metrics documents</titleabbrev>
++++
== Application metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we'll need to rework the metrics docs for some reasons:

  • the main question that we see raised is which metrics end up in service specific datastreams and which in the generic one
  • irritation around the aggregated metrics

We'll need to better cover these topics, but without over-documenting it, as the concrete (aggregated) metrics data streams are considered an internal detail, that we might change, as long as the UI changes the queries in a compatible way.
Should we have an in-depth conversation for this topic on this PR, or do you prefer a follow up issue to not slow down the structural changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense. I'd prefer to move the conversation to a separate issue.

@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

This pull request is now in conflicts. Could you fix it @bmorelli25? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ft-explore upstream/ft-explore
git merge upstream/main
git push upstream ft-explore

@bmorelli25 bmorelli25 enabled auto-merge (squash) May 16, 2023 20:42
@bmorelli25 bmorelli25 merged commit 56e5c0e into elastic:main May 16, 2023
@bmorelli25 bmorelli25 deleted the ft-explore branch May 16, 2023 20:55
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request May 23, 2023
* exploring-es-data

* remove leftover comment

* fix doc build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants