[test] add more tests for the gitMatchingGroup step #671
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
There was a problem hiding this comment.
I'd try to use a name explaining the corner case, adding the PR id in a Java comment, then the method would be self-explanatory
There was a problem hiding this comment.
I've decided to use a more meaningful test case name, since the cornercase might be misleading
v1v
changed the title
There was a problem hiding this comment.
i.e. : test_multiple_groups_with_multiple_modules_does_not_capture_module
It's more verbose but clearer IMO.
There was a problem hiding this comment.
I think this use case is almost the same than the above ones, as the exclude pattern includes a subdirectory. I would name it then: test_module_detection_with_path_in_pattern
3 participants
What does this PR do?
Add some test cases to validate a multimodule beat with some exclusions.
Why is it important?
Avoid the corner case of detecting a quite generic regex that should not apply for another beats
Related issues
Caused by elastic/beats#19985 and therefore elastic/beats#19986