This repository was archived by the owner on Oct 28, 2024. It is now read-only.
chore: support filtering the upstream cause in the isUpstreamTrigger step#1031
Merged
mdelapenya merged 10 commits intoelastic:masterfrom Mar 11, 2021
Merged
Conversation
mdelapenya
commented
Mar 11, 2021
v1v
approved these changes
Mar 11, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
cachedout
approved these changes
Mar 11, 2021
mdelapenya
changed the title
kuisathaverat
approved these changes
Mar 11, 2021
Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
v1v
reviewed
Mar 11, 2021
v1v
reviewed
Mar 11, 2021
mdelapenya
commented
Mar 11, 2021
v1v
added a commit
that referenced
this pull request
Mar 11, 2021
* upstream/master: (27 commits) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.201 chore: support filtering the upstream cause in the isUpstreamTrigger step (#1031) Slack notification with the total build time (#1033) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.200 Add withNode step (#1030) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.199 Add isStaticWorker step (#1028) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.198 add noTags - fixes #1024 (#1025) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.197 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It updates the
isUpstreamTriggerstep to identify whether the upstream trigger was caused by a PR or not, passing a filter in a backwards compatible mode.As @v1v suggested during the review, consumers will use the step exactly the same as before, but now supporting a
filterstring parameter:whenTrue(isUpstreamTrigger()) { // } whenTrue(isUpstreamTrigger(filter: 'PR-')) { // }Why is it important?
In certain cases, we want the downstream job to act in a different manner for PRs than for branches, like selecting a subset of the downstream project's test suite.
Related issues
Relates elastic/e2e-testing#873