Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Update to new schema for flaky tests#1016

Merged
cachedout merged 15 commits intoelastic:masterfrom
cachedout:flake_update
Mar 16, 2021
Merged

Update to new schema for flaky tests#1016
cachedout merged 15 commits intoelastic:masterfrom
cachedout:flake_update

Conversation

@cachedout
Copy link
Copy Markdown
Contributor

What does this PR do?

This is the first part of a request to update the APM Pipeline library to support the new flaky test schema.

It is not ready for merge. Still needs tests and to have a few items double-checked, such as whether or not the test names are aligned with the names of the actual test failures flowing into this function.

Why is it important?

Needed to restore flaky test functionality to PRs.

@cachedout cachedout requested a review from v1v March 5, 2021 18:22
Comment thread src/co/elastic/NotificationManager.groovy Outdated
@ghost
Copy link
Copy Markdown

ghost commented Mar 5, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1016 updated

  • Start Time: 2021-03-16T08:57:43.535+0000

  • Duration: 8 min 14 sec

  • Commit: 602850b

Test stats 🧪

Test Results
Failed 0
Passed 1064
Skipped 2
Total 1066

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1064
Skipped 2
Total 1066

Comment thread src/co/elastic/NotificationManager.groovy Outdated
Comment thread src/co/elastic/NotificationManager.groovy Outdated
Comment thread src/co/elastic/NotificationManager.groovy Outdated
Comment thread src/co/elastic/NotificationManager.groovy Outdated
@cachedout cachedout marked this pull request as ready for review March 9, 2021 14:43
@cachedout cachedout requested a review from v1v March 9, 2021 14:43
@botelastic botelastic Bot added the groovy label Mar 9, 2021
@cachedout cachedout changed the title [WIP] Update to new schema for flaky tests Update to new schema for flaky tests Mar 9, 2021
Comment thread vars/notifyBuildResult.txt
Comment thread vars/notifyBuildResult.groovy
Comment thread src/co/elastic/NotificationManager.groovy
Comment thread src/co/elastic/NotificationManager.groovy Outdated
@v1v
Copy link
Copy Markdown
Member

v1v commented Mar 10, 2021

elastic/beats#24464 might be the changes required in the consumers of this step

@cachedout cachedout requested a review from v1v March 15, 2021 13:18
Comment thread src/co/elastic/NotificationManager.groovy Outdated
Comment thread src/co/elastic/NotificationManager.groovy Outdated
Comment thread src/co/elastic/NotificationManager.groovy
cachedout and others added 4 commits March 15, 2021 14:01
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@cachedout cachedout requested a review from v1v March 15, 2021 14:50
@v1v v1v added the enhancement New feature or request label Mar 15, 2021
@cachedout cachedout merged commit 80cf1bb into elastic:master Mar 16, 2021
@v1v v1v mentioned this pull request Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request groovy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants