This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
fix: change default APM server_url to 'http://127.0.0.1:8200' to avoid IPv6 ambiguity #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d IPv6 ambiguity The APM agent won't *require* this change, because in the referenced change it will be adding the same default on its end. Refs: elastic/apm-agent-nodejs#3049
github-actions
bot
added
the
agent-nodejs
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
[email protected] published with this |
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Dec 8, 2022
…-client#190 (though it isn't strictly needed)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APM agent won't require this change, because in the referenced
change it will be adding the same default on its end.
Refs: elastic/apm-agent-nodejs#3049
Checklist