This repository was archived by the owner on Jan 23, 2024. It is now read-only.
Update dockerfile for .NET test to use .NET6 #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump .NET version to .NET6
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Contributor
Author
|
I see strange failures, but that does not seem to be related to the PR - it does not get to the stage where we'd use the updated docker file. Could someone please help out? |
Member
|
As far as I see the docker image for the dotnet service failed to be built: Can you run the below command locally? ELASTIC_STACK_VERSION=8.1.0 BUILD_OPTS="--apm-log-level=debug --build-parallel" .ci/scripts/build-docker-all.sh |
Contributor
Author
|
Found it, this was the issue: Pushed a fix, it's green now. Ready for review. |
v1v
approved these changes
Jan 26, 2022
Member
|
@Mergifyio backport 5.x |
Contributor
🟠 Waiting for conditions to match
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
* Update Dockerfile Bump .NET version to .NET6 * Update Dockerfile (cherry picked from commit 5b2ed7a)
Contributor
✅ Backports have been created
|
Member
|
@Mergifyio backport 5.x |
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
* Update Dockerfile Bump .NET version to .NET6 * Update Dockerfile (cherry picked from commit 5b2ed7a)
Contributor
✅ Backports have been created
|
v1v
pushed a commit
that referenced
this pull request
Jan 27, 2022
* Update Dockerfile Bump .NET version to .NET6 * Update Dockerfile (cherry picked from commit 5b2ed7a) Co-authored-by: Gergely Kalapos <[email protected]>
v1v
pushed a commit
that referenced
this pull request
Jan 27, 2022
* Update Dockerfile Bump .NET version to .NET6 * Update Dockerfile (cherry picked from commit 5b2ed7a) Co-authored-by: Gergely Kalapos <[email protected]>
v1v
added a commit
to v1v/apm-integration-testing
that referenced
this pull request
Feb 3, 2022
…main-reference * upstream/main: Update dockerfile for opbeans-dotnet to use .NET6 (elastic#1423) versions: wrong versions (elastic#1414) Update dockerfile for .NET test to use .NET6 (elastic#1412) apm: Neutral naming for apm-agent-java (elastic#1375) docker/go: use go.elastic.co/apm/v2 (elastic#1403) docker/opbeans/go: strip vN from replacement path (elastic#1401)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump .NET version to .NET6
What does this PR do?
In the main agent repo, I'm updating the code base to build and test on .NET 6. This PR updates the docker file where we build the agent as well.
Why is it important?
Otherwise we can't build the tests.
Related issues
PR in the .NET agent repo: elastic/apm-agent-dotnet#1605