Updated otlp network connection attributes per otel semconv #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added attribute processing for otlp log to include network connection type.
bryce-b
force-pushed
the
update-optl-log-attributes
branch
from
aa2eab2 to
a84baee
Compare
kruskall
reviewed
Dec 29, 2023
kruskall
approved these changes
Jan 5, 2024
11 tasks
|
Quickly tested this with BC5 and a small adaption of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added attribute processing for otlp log to include network connection type.
This solves #195
Additionally, updates the otel semconv per https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/attributes.md#network-connection-and-carrier-attributes