fix: do not close log processing channel if logs api is disabled #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the extension relies on 3 mechanisms to exit event processing: - agent flush signal - log processing done - event deadline timeout When the logs api/processing is disabled the log processing is always done and event processing will exit immediately. To fix this ignore log processing signal and only rely on agent flush or event deadline if log processing is disabled.
rockdaboot
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the extension relies on 3 mechanisms to exit event processing:
When the logs api/processing is disabled the log processing is always done and event processing will exit immediately.
To fix this ignore log processing signal and only rely on agent flush or event deadline if log processing is disabled.