Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use native test env variable #233

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

kruskall
Copy link
Member

Go 1.17 added support for setting an environment variable for the
duration of test.
t.Setenv provides automatic cleanup of env variables after the
test ends.

See https://go.dev/doc/go1.17#testing

Go 1.17 added support for setting an environment variable for the
duration of test.
t.Setenv provides automatic cleanup of env variables after the
test ends.

See https://go.dev/doc/go1.17#testing
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jul 14, 2022
@apmmachine
Copy link

apmmachine commented Jul 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-14T20:59:49.478+0000

  • Duration: 8 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 220
Skipped 4
Total 224

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kruskall
Copy link
Member Author

/test

Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kruskall kruskall merged commit 7b95912 into elastic:main Jul 18, 2022
@kruskall kruskall deleted the feat/t-setenv branch July 18, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants