chore(dev): fix span duration in tests#778
Conversation
vigneshshanmugam
commented
May 4, 2020
- Our unit tests for the latest server snapshot started breaking because of the new changes in Server which disallows spans with negative duration docs/spec: require duration >= 0 apm-server#3721. This PR fixes the span with correct duration.
hmdhk
left a comment
There was a problem hiding this comment.
@vigneshshanmugam , Let's merge once tests are green.
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 92.20% 94.33% +2.12%
==========================================
Files 50 49 -1
Lines 2694 2171 -523
Branches 579 426 -153
==========================================
- Hits 2484 2048 -436
+ Misses 207 120 -87
Partials 3 3
|
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|