Skip to content

fix(rum-core): add missing tags in errors context when compressed#1707

Merged
david-luna merged 1 commit intomainfrom
fix-add-error-labels
Mar 5, 2026
Merged

fix(rum-core): add missing tags in errors context when compressed#1707
david-luna merged 1 commit intomainfrom
fix-add-error-labels

Conversation

@david-luna
Copy link
Copy Markdown
Member

#1594 added support for error labels but it was incomplete. The compression mechanism was not taking in consideration the new property. The result is error labels not being sent to the APM server. This PR adds the labels in the compression and a test to make sure the right payload is sent to the server

Supersedes #1673
Fixes #1672

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Copy Markdown
Member

trentm commented Mar 3, 2026

.

@trentm
Copy link
Copy Markdown
Member

trentm commented Mar 3, 2026

Attempting to approve, but GH is giving me errors.

@david-luna
Copy link
Copy Markdown
Member Author

Attempting to approve, but GH is giving me errors.

Checking if I get errors too

Copy link
Copy Markdown
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-luna david-luna merged commit 5ed64fe into main Mar 5, 2026
20 checks passed
@david-luna david-luna deleted the fix-add-error-labels branch March 5, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

captureError sending labels not working

2 participants