Skip to content

remove passing component property when route is not instrumented #401

@vigneshshanmugam

Description

@vigneshshanmugam
  • When the component property is not instrumented via <ApmRoute> component, we should not override the props passed down to Route component. This creates a memory leak warning in React and also its a bug in general.

https://github.com/elastic/apm-agent-rum-js/blob/master/packages/rum-react/src/get-apm-route.js#L36

Found this while instrumenting Kibana

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions