Validate span.type and .subtype against shared spec#1030
Validate span.type and .subtype against shared spec#1030mikker merged 14 commits intoelastic:masterfrom mikker:shared-span-types
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
SylvainJuge
left a comment
There was a problem hiding this comment.
Just a few minor questions/comments on my end for the shared JSON spec.
I start to feel that we could add another descriptive field to indicate which agent is using what, that will later help to align and find which ones are mostly used, and which ones are the exceptions & oddities, what do you think ?
|
I think marking agent langs in the spec is a good idea so long as we are in the process of aligning 👍 |
|
I've just updated the original PR (elastic/apm#443) with |
|
There are only a few differences with the elastic/apm#443 PR, thus you can directly update it once this is merged without doing a PR on PR :-). |
Closes #1018
Found out that we still sent types in the legacy joined formTurns out this is still Good Behaviour™type.subtype.action.