Skip to content

docs: fix links#1854

Merged
bmorelli25 merged 2 commits intoelastic:mainfrom
bmorelli25:fix-redirects
Jun 13, 2023
Merged

docs: fix links#1854
bmorelli25 merged 2 commits intoelastic:mainfrom
bmorelli25:fix-redirects

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Jun 13, 2023

Summary

This PR fixes the links broken in elastic/apm-server#10894.

A list of broken links is here elastic/apm-server#10891 (comment).

@bmorelli25 bmorelli25 requested a review from a team June 13, 2023 00:07
@bmorelli25 bmorelli25 self-assigned this Jun 13, 2023
@bmorelli25 bmorelli25 enabled auto-merge (squash) June 13, 2023 19:31
@bmorelli25 bmorelli25 merged commit 603564f into elastic:main Jun 13, 2023
@bmorelli25
Copy link
Member Author

ohhhh docs ci isn't required so this auto-merged and broke the doc build

@bmorelli25 bmorelli25 deleted the fix-redirects branch June 13, 2023 19:48
@basepi
Copy link
Contributor

basepi commented Jun 13, 2023

ohhhh docs ci isn't required so this auto-merged and broke the doc build

I did notice it was red and assumed you were on it 😱

We don't require docs build because it's out of our control, I just never merge if it's red unless I know it's an upstream issue or we didn't touch docs.

@bmorelli25 bmorelli25 mentioned this pull request Jun 13, 2023
@bmorelli25
Copy link
Member Author

We don't require docs build because it's out of our control, I just never merge if it's red unless I know it's an upstream issue or we didn't touch docs.

Makes sense. I'll make a note not to use auto-merge in your repo for doc PRs. And yes, I'm on it!

@basepi
Copy link
Contributor

basepi commented Jun 13, 2023

I'll make a note not to use auto-merge in your repo for doc PRs.

Honestly we should probably make it required again. I just don't have the perms to do that anymore, so we'll need to reach out to robots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants