Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump mysql2 from 3.11.4 to 3.11.5 #4334

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 2, 2024

Bumps mysql2 from 3.11.4 to 3.11.5.

Release notes

Sourced from mysql2's releases.

v3.11.5

3.11.5 (2024-11-28)

Bug Fixes

  • fix datetime fields returned without time part when time is 00:00:00 (#3204) (bded498)
  • resolve circular dependencies (#3081) (d5a76e6)
  • Deno v2 requires commonjs type explicitly (#3209) (cdc9415)
Changelog

Sourced from mysql2's changelog.

3.11.5 (2024-11-28)

Bug Fixes

  • 1040 datetime fields returned without time part when time is 00:00:00 (#3204) (bded498)
  • circular dependencies (#3081) (d5a76e6)
  • Deno v2 requires commonjs type explicitly (#3209) (cdc9415)
Commits
  • 8a44da2 chore(master): release 3.11.5 (#3207)
  • 6b746fc build(deps-dev): bump @​types/node from 22.10.0 to 22.10.1 (#3244)
  • 87a81a3 build(deps): bump lucide-react from 0.460.0 to 0.462.0 in /website (#3248)
  • 34c8654 build(deps-dev): bump @​types/node from 22.9.1 to 22.10.1 in /website (#3246)
  • 62d72fc build(deps): bump @​easyops-cn/docusaurus-search-local in /website (#3245)
  • adc49d7 build(deps-dev): bump @​docusaurus/tsconfig in /website (#3232)
  • c96dded build(deps-dev): bump prettier from 3.3.3 to 3.4.1 in /website (#3241)
  • 5e1031a build(deps-dev): bump prettier from 3.4.0 to 3.4.1 (#3242)
  • 2d1564f build(deps-dev): bump @​docusaurus/eslint-plugin in /website (#3231)
  • 0898db5 build(deps-dev): bump @​docusaurus/module-type-aliases in /website (#3230)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mysql2](https://github.com/sidorares/node-mysql2) from 3.11.4 to 3.11.5.
- [Release notes](https://github.com/sidorares/node-mysql2/releases)
- [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md)
- [Commits](sidorares/node-mysql2@v3.11.4...v3.11.5)

---
updated-dependencies:
- dependency-name: mysql2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 2, 2024
@dependabot dependabot bot requested a review from a team December 2, 2024 00:27
@david-luna
Copy link
Member

It seems latest update makes the test stall. I can reproduce locally

@david-luna david-luna self-assigned this Dec 2, 2024
@david-luna
Copy link
Member

Probably related to sidorares/node-mysql2#3081

@david-luna david-luna requested a review from trentm December 4, 2024 09:55
@trentm
Copy link
Member

trentm commented Dec 5, 2024

Rerunning tests. They failed because GH had an incident.

@trentm
Copy link
Member

trentm commented Dec 5, 2024

@david-luna All the test jobs appear to be stalled. They are not making progress after the end of mysql2-related tests. I will cancel those jobs now.

You were able to repro locally. Was the local repro fixed by your changes?

@david-luna
Copy link
Member

@david-luna All the test jobs appear to be stalled. They are not making progress after the end of mysql2-related tests. I will cancel those jobs now.

You were able to repro locally. Was the local repro fixed by your changes?

This is due to my last commit, sorry. I decided to have a solution more similar to https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2579/files where it's checking the type of the specific properties to patch.

3ea4243 should fix it :)

Copy link
Member

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav

@david-luna david-luna merged commit 3e615aa into main Dec 6, 2024
197 checks passed
@david-luna david-luna deleted the dependabot/npm_and_yarn/mysql2-3.11.5 branch December 6, 2024 12:19
@david-luna david-luna mentioned this pull request Dec 9, 2024
trentm pushed a commit that referenced this pull request Jan 7, 2025
Add instrumentation for the new BaseConnection class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants