Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: instrument core modules imported with require('node:...') #2868

Merged
merged 7 commits into from
Aug 12, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Aug 10, 2022

Starting in node v14.18.0, support for identifying core node modules
with the 'node:'-prefix was added:
https://nodejs.org/api/modules.html#core-modules

Closes: #2816

checklist

Starting in node v14.18.0, support for identifying core node modules
with the 'node:'-prefix was added:
https://nodejs.org/api/modules.html#core-modules

Closes: #2816
@trentm trentm self-assigned this Aug 10, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 10, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Aug 10, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-12T18:46:04.781+0000

  • Duration: 21 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 259204
Skipped 0
Total 259204

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm marked this pull request as ready for review August 12, 2022 18:45
@trentm trentm requested a review from astorm August 12, 2022 18:46
@trentm trentm merged commit 0c3cfd8 into main Aug 12, 2022
@trentm trentm deleted the trentm/node-prefixed-core-modules branch August 12, 2022 21:40
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
…tic#2868)

Starting in node v14.18.0, support for identifying core node modules
with the 'node:'-prefix was added:
https://nodejs.org/api/modules.html#core-modules

Closes: elastic#2816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core modules imported with require('node:...') are not instrumented
3 participants