Shared JSON spec for span types/subtypes#1812
Merged
SylvainJuge merged 31 commits intoelastic:masterfrom Jun 2, 2021
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
…gent-java into span-type-subtype-spec
Member
Author
|
See elastic/apm#443 PR for adding this to shared specifications. |
eyalkoren
reviewed
May 31, 2021
Contributor
eyalkoren
left a comment
There was a problem hiding this comment.
LGTM, few minor comments and one question about the spec itself - for a given type, is null subtype allowed when the spec defines a list of subtypes?
| * Sets all optional checks to their default value (enabled), should be used as a shortcut to reset mock reporter state | ||
| * after/before using it for a single test execution | ||
| */ | ||
| public void resetChecks() { |
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
...ent-plugins/apm-process-plugin/src/main/java/co/elastic/apm/agent/process/ProcessHelper.java
Show resolved
Hide resolved
eyalkoren
reviewed
Jun 1, 2021
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
eyalkoren
approved these changes
Jun 2, 2021
Contributor
eyalkoren
left a comment
There was a problem hiding this comment.
LGTM! One minor suggestion
Co-authored-by: eyalkoren <41850454+eyalkoren@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creates and enforces JSON spec for all the span types/subtypes that are used in the Java agent
This is a preliminary step to having a shared spec applied to all APM agents.
Related PR for all agents : elastic/apm#443
Checklist
foo.*type.null(not provided) or""(empty) sub-types:Solution (1): normalize tonullinstead of empty and treatsub-typeas optionalnullinstead of empty and allownullon some types (not all of them).processtype that uses binary name as sub-type (or find a proper way to fix it).subtypethat was using binary name, it's already provided innametemplatetype that uses template engine name as sub-type (and is also very platform-specific)typeand notsubtypeas it's really platform-specificcache.redistodb.redisfor consistencycustomas default span type instead ofunknown