Skip to content

ci: use the releaseNotification step#1659

Merged
v1v merged 3 commits intoelastic:masterfrom
v1v:feature/reuse-step-notification
May 17, 2021
Merged

ci: use the releaseNotification step#1659
v1v merged 3 commits intoelastic:masterfrom
v1v:feature/reuse-step-notification

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Feb 11, 2021

What

Use elastic/apm-pipeline-library#976 to simplify the body manipulation
Enable email/slack communications when a tag release has created

Actions

  • Need the above-mentioned PR and also a release ✅
  • email address?

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1659 (3665a17) into master (3714579) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1659   +/-   ##
=========================================
  Coverage     58.93%   58.94%           
  Complexity       92       92           
=========================================
  Files           404      404           
  Lines         18440    18440           
  Branches       2561     2561           
=========================================
+ Hits          10868    10869    +1     
- Misses         6802     6803    +1     
+ Partials        770      768    -2     
Impacted Files Coverage Δ Complexity Δ
...ic/apm/agent/profiler/collections/LongHashSet.java 16.66% <0.00%> (ø) 0.00% <0.00%> (ø%)
...o/elastic/apm/agent/profiler/SamplingProfiler.java 73.52% <0.00%> (+0.23%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3714579...3665a17. Read the comment docs.

@ghost
Copy link
Copy Markdown

ghost commented Feb 11, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1659 updated

  • Start Time: 2021-05-14T08:17:26.719+0000

  • Duration: 55 min 45 sec

  • Commit: 7587645

Test stats 🧪

Test Results
Failed 0
Passed 1815
Skipped 14
Total 1829

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1815
Skipped 14
Total 1829

@SylvainJuge SylvainJuge added the automation Tests & automation that help build & maintain the project label Mar 1, 2021
@SylvainJuge
Copy link
Copy Markdown
Member

@v1v do you think we could review & merge this as-is, or does it still needs few changes before it's ready ?

As it's release we might not be able to test it properly until the next release, but given it's only about notifications we should not expect breaking changes here.

Comment thread .ci/release/Jenkinsfile Outdated
@v1v v1v marked this pull request as ready for review March 29, 2021 12:13
@v1v v1v requested review from a team March 29, 2021 12:13
Copy link
Copy Markdown
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread .ci/release/Jenkinsfile Outdated
v1v and others added 2 commits March 30, 2021 09:18
Co-authored-by: cachedout <mike.place@elastic.co>
@v1v v1v merged commit baa3841 into elastic:master May 17, 2021
@v1v v1v self-assigned this May 17, 2021
@v1v v1v deleted the feature/reuse-step-notification branch May 17, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java automation Tests & automation that help build & maintain the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants