Avoid segfault when executing tests with JDK < 11.0.4#1272
Merged
felixbarny merged 1 commit intoelastic:masterfrom Jul 17, 2020
Merged
Avoid segfault when executing tests with JDK < 11.0.4#1272felixbarny merged 1 commit intoelastic:masterfrom
felixbarny merged 1 commit intoelastic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#1230 required us to update to the latest JDK in order to avoid crashes when executing tests.
I've investigated a little more. While I can't say which parts of the PR triggered the segfault, I can rule out a few options:
PostProcessor/@AssignToThe segfault even triggers when only the
testLegacyDefaultDisabledInstrumentationtest is active inInstrumentationTestand when using@Advice.Return(readOnly = false)instead of@AssignTo.Return.As described in the JDK tracker https://bugs.openjdk.java.net/browse/JDK-8210457, the issue occurs when there's a retransformation happening concurrently to the
StackWalkertraversing the stack.The workaround is to only create the logger once.
Checklist
I have updated CHANGELOG.asciidoc