Instrument Runnables/Callables instead of wrapping them#1206
Merged
felixbarny merged 15 commits intoelastic:masterfrom Jun 17, 2020
Merged
Instrument Runnables/Callables instead of wrapping them#1206felixbarny merged 15 commits intoelastic:masterfrom
felixbarny merged 15 commits intoelastic:masterfrom
Conversation
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
============================================
+ Coverage 59.38% 59.75% +0.37%
- Complexity 86 247 +161
============================================
Files 339 343 +4
Lines 16847 17305 +458
Branches 2468 2560 +92
============================================
+ Hits 10004 10341 +337
- Misses 6203 6288 +85
- Partials 640 676 +36
Continue to review full report at Codecov.
|
eyalkoren
reviewed
Jun 15, 2020
apm-agent-core/src/main/java/co/elastic/apm/agent/bci/ElasticApmAgent.java
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/util/CallDepth.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/util/CallDepth.java
Outdated
Show resolved
Hide resolved
...apm-java-concurrent-plugin/src/main/java/co/elastic/apm/agent/concurrent/JavaConcurrent.java
Show resolved
Hide resolved
...apm-java-concurrent-plugin/src/main/java/co/elastic/apm/agent/concurrent/JavaConcurrent.java
Show resolved
Hide resolved
...apm-java-concurrent-plugin/src/main/java/co/elastic/apm/agent/concurrent/JavaConcurrent.java
Show resolved
Hide resolved
...apm-java-concurrent-plugin/src/main/java/co/elastic/apm/agent/concurrent/JavaConcurrent.java
Outdated
Show resolved
Hide resolved
...apm-java-concurrent-plugin/src/main/java/co/elastic/apm/agent/concurrent/JavaConcurrent.java
Show resolved
Hide resolved
...apm-java-concurrent-plugin/src/main/java/co/elastic/apm/agent/concurrent/JavaConcurrent.java
Show resolved
Hide resolved
...c/main/java/co/elastic/apm/agent/concurrent/RunnableCallableForkJoinTaskInstrumentation.java
Show resolved
Hide resolved
eyalkoren
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
closes #987
Bonus content:
ForJoinPoolandScheduledExecutorServiceExecutorService#invokeAnyandExecutorService#invokeAllChecklist
[ ] Added an API method or config option? Document in which version this will be introduced[ ] I have made corresponding changes to the documentation