Skip to content

Keep spans active on AsyncHandler#onStream#1175

Merged
felixbarny merged 2 commits intoelastic:masterfrom
milanvdm:keep-spans-active-on-stream-async-http
May 11, 2020
Merged

Keep spans active on AsyncHandler#onStream#1175
felixbarny merged 2 commits intoelastic:masterfrom
milanvdm:keep-spans-active-on-stream-async-http

Conversation

@milanvdm
Copy link
Contributor

@milanvdm milanvdm commented May 8, 2020

What does this PR do?

Currently, when using a custom StreamedAsyncHandler with the AsyncHttpClient, there is no active span in the onStream method.
This PR makes sure that the span is activated when entering onStream

Related to #1172

Checklist

  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated CHANGELOG.asciidoc
  • I have updated supported-technologies.asciidoc
  • Added an API method or config option? Document in which version this will be introduced
  • Added an instrumentation plugin? How did you make sure that old, non-supported versions are not instrumented by accident?

@ghost
Copy link

ghost commented May 8, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-05-10T21:50:22.789+0000

  • Duration: 37 min 17 sec (2237388)

  • Commit: ec2b7eb

Test stats 🧪

Test Results
Failed 0
Passed 1261
Skipped 12
Total 1273

@felixbarny felixbarny merged commit 3882444 into elastic:master May 11, 2020
@felixbarny felixbarny mentioned this pull request May 28, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants